Skip to content

Add InlineAnnotation #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

Add InlineAnnotation #15

wants to merge 21 commits into from

Conversation

zbraniecki
Copy link
Contributor

This is an experimental concept to annotate source inline on top of annotating it below.

@zbraniecki
Copy link
Contributor Author

This is an experiment in extending the API to support inline annotations.

I'm not sure if it's worth it, but wanted to give it a try and got it to work!

Screen Shot 2019-10-29 at 2 16 01 PM

Alternatively, I was thinking of extending SourceAnnotation to allow users to specify the display format - under, inline or both, but that made the API a bit less readable IMO.

@zbraniecki
Copy link
Contributor Author

All I had to add to the examples/format.rs is:

Screen Shot 2019-10-29 at 2 17 54 PM

@zbraniecki
Copy link
Contributor Author

@CAD97, @wycats, @brendanzab - thoughts?

I think it may be a path forward to allow for source coloring, if we enable custom "styles" and allow for such annotations. Not sure if it's the best way, but it's an option.

My primary goal is to visually aid analyzing the slice, not syntax coloring.

@epage
Copy link
Contributor

epage commented Mar 13, 2024

#97 will expand the API to allow different types of annotations.

If someone wants to move this forward from where we are at, I'd recommend creating an issue to discuss the idea.

@epage epage closed this Mar 13, 2024
@epage epage deleted the cleanup-inline branch March 13, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants